ENG-1896 Remove legacy anchor-backed discourse node type support#1135
Conversation
- Remove anchor-backed discourse node creation from getDiscourseNodes - Remove anchor selection logic from getDiscourseContextResults - Preserve existing context selection behavior This removes unused legacy functionality where relations with 'anchor' in their triples would generate discourse nodes. Per the issue, this feature is no longer used and has no place to surface in the current discourse context UI.
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
mdroidian
changed the title
|
@codex review |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4914088315
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
PR size/scope checkThis PR is over our review-size guideline.
Please split this into smaller PRs unless there is a clear reason the changes need to land together. If keeping it as one PR, please add a brief justification covering:
|
- Updated getDiscourseNodes to only accept settingsSnapshot, removing the relations parameter. - Adjusted multiple components and utility functions to align with the new getDiscourseNodes signature. - Ensured consistent behavior across the application by standardizing how discourse nodes are retrieved.
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
This PR removes legacy
anchor-backed discourse node type support from the canvas node type migration path, as requested in Linear issue DIS-608.Changes
Removed anchor-backed discourse node creation from
getDiscourseNodes():anchorin their triplesRemoved anchor selection logic from
getDiscourseContextResults():anchorin relation triplesbuildSelections()functionPreserved existing functionality:
Context
Per Joel's explanation,
anchorwas a special keyword for choosing the block displayed as context for a given relation/edge between nodes. However, there is currently no place for this to show up in the discourse context UI, making this functionality unused and unsupported.The removal simplifies the canvas node type migration flow without affecting any active features.
Testing
pnpm run check-types)pnpm run lint)Related Issue
Closes DIS-608
Linear Issue: ENG-1896